pages/NGO/index.tsx (2)

23-34: ⚡ Quick win

observer 包装可移除

组件内部未使用任何 MobX observable 状态，observer 高阶组件带来的额外订阅开销是不必要的。useContext(I18nContext) 返回的 t 函数是普通 React Context，不需要 MobX 响应式追踪。

♻️ 建议修改

-const OrganizationHomePage: FC<InferGetStaticPropsType<typeof getStaticProps>> = observer(props => {
+const OrganizationHomePage: FC<InferGetStaticPropsType<typeof getStaticProps>> = props => {
   const { t } = useContext(I18nContext);
 
   return (
     <Container className="py-5">
       <PageHead title={t('China_NGO_DB')} />
       <h1 className="text-center my-4">{t('China_NGO_DB')} 2.0</h1>
 
       <ZodiacBar {...props} itemOf={year => ({ title: year, link: `/NGO/${year}` })} />
     </Container>
   );
-});
+};

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pages/NGO/index.tsx` around lines 23 - 34, The OrganizationHomePage component
is unnecessarily wrapped with the observer higher-order component from MobX,
which adds subscription overhead even though the component contains no MobX
observable state. The only state accessed is from useContext(I18nContext), which
is standard React Context and does not require MobX reactive tracking. Remove
the observer wrapper from the component declaration so it becomes a regular FC
without the MobX observer higher-order component.

---

12-21: 💤 Low value

建议添加 revalidate 以支持增量静态再生成（ISR）

当前 getStaticProps 成功路径未设置 revalidate，页面数据仅在构建时生成，后续不会自动更新。如果年份范围数据可能变化，建议添加 revalidate 以启用 ISR：

♻️ 建议修改

-  return { props: { startYear, endYear } };
+  return { props: { startYear, endYear }, revalidate: 60 * 60 }; // 每小时重新验证

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pages/NGO/index.tsx` around lines 12 - 21, The getStaticProps function in
pages/NGO/index.tsx is missing the revalidate property in its return statement,
which prevents Incremental Static Regeneration (ISR) from working. Add a
revalidate property to the object returned by getStaticProps to specify how
often the page should be regenerated in seconds. This will allow the page data,
including the year range retrieved from OrganizationModel.getYearRange(), to be
automatically updated at regular intervals instead of only at build time.

pages/NGO/[year]/index.tsx (2)

55-57: ⚡ Quick win

两个年份页面成功路径均缺少 revalidate，数据将永不自动更新。 当前实现仅在错误路径设置了 revalidate: Minute / Second，但成功生成的页面无法通过 ISR 自动刷新，导致数据一旦生成便永久静态化。

• pages/NGO/[year]/index.tsx#L55-L57：在 return { props: { year, statistic } } 后添加 revalidate: Minute / Second
• pages/NGO/[year]/landscape.tsx#L44-L46：在 return { props: JSON.parse(JSON.stringify({ typeMap })) } 后添加 revalidate: Minute / Second

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pages/NGO/`[year]/index.tsx around lines 55 - 57, The getStaticProps
functions in both affected files are missing the revalidate property in their
successful return paths, which prevents ISR automatic updates for the generated
pages. In pages/NGO/[year]/index.tsx at lines 55-57, add revalidate: Minute /
Second (or appropriate constant value) to the returned object after the props
property in the return statement. Similarly, in pages/NGO/[year]/landscape.tsx
at lines 44-46, add the same revalidate property to the returned object after
returning the typeMap props. This ensures that the successfully generated pages
will automatically refresh at the specified interval, matching the revalidate
configuration already present in the error paths.

---

65-88: 💤 Low value

observer 包装可移除

OrganizationPage 组件未直接观察任何 MobX observable 状态。statistic 和 year 都是从 props 获取的普通对象，移除 observer 可减少不必要的订阅开销。

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pages/NGO/`[year]/index.tsx around lines 65 - 88, Remove the observer HOC
wrapper from the OrganizationPage component definition. The component does not
directly observe any MobX observable state, and both the year and statistic
props are plain objects rather than observables, making the observer wrapper
unnecessary. Simply unwrap the component function from the observer call in the
component assignment.

pages/NGO/[year]/landscape.tsx (1)

16-30: ⚖️ Poor tradeoff

getStaticPaths 逻辑与 [year]/index.tsx 重复

此处的年份获取逻辑与 pages/NGO/[year]/index.tsx 中的 getStaticPaths 完全相同。建议抽取为共享辅助函数以遵循 DRY 原则：

♻️ 建议抽取共享函数

// models/Organization.ts 或单独的 helpers 文件
export async function getNGOYearPaths() {
  await lark.getAccessToken();
  
  const yearStore = new OrganizationYearStatisticModel();
  yearStore.client = lark.client;
  
  const years = await yearStore.getAll();
  
  return years
    .map(({ name }) => name && { params: { year: name! } })
    .filter(Boolean) as { params: { year: string } }[];
}

然后在两个页面中：

export const getStaticPaths: GetStaticPaths<{ year: string }> = async () => ({
  paths: await getNGOYearPaths(),
  fallback: 'blocking',
});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pages/NGO/`[year]/landscape.tsx around lines 16 - 30, The getStaticPaths
function in this file contains the same logic as another getStaticPaths
implementation: calling lark.getAccessToken, creating an
OrganizationYearStatisticModel instance, and calling getAll to retrieve and
transform years. Extract this duplicated logic into a shared helper function
(e.g., getNGOYearPaths) that handles the token retrieval, year store
initialization, and transformation, returning the formatted paths array. Then
refactor the getStaticPaths function in this file to call the helper function
instead of duplicating the inline logic. Apply this same refactoring to the
other file with identical getStaticPaths logic to eliminate code duplication.